refactor: cleanup match ticker step 3#7694
Merged
Merged
Conversation
Rathoz
force-pushed
the
cleanup-matchticker-2
branch
from
c3940da to
a07d24c
Compare
Rathoz
force-pushed
the
cleanup-matchticker-3
branch
from
1023823 to
d278a5b
Compare
Rathoz
force-pushed
the
cleanup-matchticker-2
branch
from
e67ff8d to
7e97926
Compare
Rathoz
force-pushed
the
cleanup-matchticker-3
branch
from
d278a5b to
c500892
Compare
Rathoz
force-pushed
the
cleanup-matchticker-3
branch
from
c500892 to
57b46a8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the match ticker pipeline to pass parsed MatchGroupUtilMatch objects through the controller and into the ticker wrapper, and to carry per-game display metadata via a dedicated gameData object instead of embedding “asGame” fields onto the match table.
Changes:
MatchTickerController.fetchMatches()now converts LPDB records toMatchGroupUtilMatchearly and returns{match=..., gameData=...}entries.- Per-game expansion now returns
{match=..., gameData=...}records and the ticker wrapper consumes them directly. - Removes configurable query column selection in favor of a fixed
QUERY_COLUMNSlist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lua/wikis/commons/Widget/Match/Ticker/Wrapper.lua | Updates wrapper to consume {match, gameData} entries and pass both to MatchCard. |
| lua/wikis/commons/MatchTicker/Controller.lua | Refactors LPDB parsing/expansion/sorting to operate on parsed matches and emit {match, gameData} records. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to remove the
MatchGroupUtil.matchFromRecordfrom the Widget. Most of the changes is towards that, with some minor cleanupHow did you test this change?
dev